gh-127353: Allow to force color output on Windows V2 #127926
Merged
+51
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hugovk, could you check this PR please? |
ZeroIntensity
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @ZeroIntensity for commit a50e877 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
hugovk
reviewed
Dec 13, 2024
hugovk
added
the
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
hugovk
approved these changes
Dec 14, 2024
There was a problem hiding this comment.
Thank you!
This is now passing on all the buildbots, except for two which are unrelated (it's #125588 (comment)).
|
Thanks @PalmtopTiger for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 14, 2024
…127926) (cherry picked from commit 0ac40acec045c4ce780cf7d887fcbe4c661e82b7) Co-authored-by: Andrey Efremov <[email protected]>
|
GH-127944 is a backport of this pull request to the 3.13 branch. |
|
Let's hope this doesn't break anything else! |
|
Yeah, will wait until tomorrow before merging the backport :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to force color output on Windows and brings the behavior of can_colorize function into compliance with POSIX. Second version of #127354 with fixed tests.